2016-03-11  TJ Saunders <tj@castaglia.org>

	* RELEASE_NOTES: Updated release notes to mention DH selection
	issue.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* README.md: Update link to shields.io badge for latest release.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* README.md, contrib/dist/rpm/proftpd.spec, include/version.h: 
	Updating files for 1.3.6rc3 development.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* NEWS: Update NEWS with release date.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* include/version.h: Preparing for RC2 release.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/rfc4716.c,
	tests/t/etc/modules/mod_sftp/authorized_rsa_keys_no_nl,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Reproduce, and fix,
	the case where mod_sftp does not handle public key files which do
	not end in a newline.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* NEWS: Update NEWS with fix for Bug#4230.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #226 from proftpd/tls-dhparam-ignored-bug4230 Bug#4230: TLSDHParamFile directive appears ignored because
	unexpected…

2016-03-10  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c,
	tests/t/lib/ProFTPD/Tests/Config/DisplayQuit.pm: If DisplayQuit is
	configured with a non-path, make sure we handle it properly.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* modules/mod_xfer.c,
	tests/t/lib/ProFTPD/Tests/Config/DisplayFileTransfer.pm: If the
	configured DisplayFileTransfer file is not able to be handled
	successfully, don't penalize/close the data transfer connection for
	it.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* contrib/mod_wrap.c: Sigh.  Declared right variable in wrong
	location.  Trying again.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #228 from proftpd/json-no-stdbool-dependency Remove the JSON implementation's dependence on stdbool.h, on the
	assu…

2016-03-10  TJ Saunders <tj@castaglia.org>

	* doc/modules/mod_core.html: Fix the documented default
	TimeoutLinger value.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* contrib/mod_wrap.c: Address compiler warnings.

2016-03-10  TJ Saunders <tj@castaglia.org>

	* modules/mod_facl.c: Make sure the module-unload event listener is
	conditionally compiled with the same conditions as its usage.

2016-03-09  TJ Saunders <tj@castaglia.org>

	* : commit f9e85236e76703303ecad3c16951ac623ec34e5a Author: TJ
	Saunders <tj@castaglia.org> Date:   Wed Mar 9 16:10:11 2016 -0800

2016-03-09  TJ Saunders <tj@castaglia.org>

	* src/netacl.c, tests/api/netacl.c: Adding tests showing that we
	properly handle "0.0.0.0/0" as a netacl expression.

2016-03-08  TJ Saunders <tj@castaglia.org>

	* : commit 35455b027ba9a315109035e117bd4890781ee489 Merge: 57ef0cd
	d49387e Author: TJ Saunders <tj@castaglia.org> Date:   Tue Mar 8
	23:04:55 2016 -0800

2016-03-08  TJ Saunders <tj@castaglia.org>

	* include/netacl.h, src/netacl.c, tests/api/netacl.c: Provide a
	pr_netacl_get_str2() function for getting string versions of ACLs
	without the added description that pr_netacl_get_str() adds.

2016-03-08  TJ Saunders <tj@castaglia.org>

	* RELEASE_NOTES: Fleshing out the release notes, as we're getting
	very close to release.

2016-03-08  TJ Saunders <tj@castaglia.org>

	* doc/modules/mod_log.html: Add docs for the added %{file-size} and
	%{transfer-type} LogFormat variables.

2016-03-08  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls.c: Bug#4230: TLSDHParamFile directive appears
	ignored because unexpected DH is chosen.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* doc/contrib/mod_auth_otp.html: Minor updates/fixes to the
	mod_auth_otp docs.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* doc/contrib/mod_auth_otp.html: Add required OpenSSL attributions.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* include/ccan-json.h, lib/ccan-json.c: Attempt to fix/address
	compiler errors on different platforms (e.g. HP-UX) by not reusing
	the same name for a struct and its typedef.  Also avoid
	re-typedef'ing uchar_t.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c, contrib/mod_sftp/scp.c: Clear the internal
	statcache in a few more places when handling SFTP, SCP.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c, modules/mod_site.c, modules/mod_xfer.c: More
	places where the internal cache should be cleared first.

2016-03-04  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c: Another place where we need to clear the
	internal statcache.

2016-02-29  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #223 from proftpd/core-str-hex2bin Add symmetric String API function for converting from hex string to
	b…

2016-02-25  TJ Saunders <tj@castaglia.org>

	* modules/mod_ctrls.c: If there are issues creating the
	ControlsSocket, log them at the NOTICE level, rather than in a
	ControlsLog (which not be opened anyway).

2016-02-25  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c, src/fsio.c: When the pr_fs_clear_cache2()
	function is used to clear the statcache, generate an event for any
	OTHER modules which might also be doing caching (e.g.
	mod_statcache), so that they too can clear their cached stat data.

2016-02-25  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c: Make mod_statcache less intrusive when it
	encounters an error when handling an FSIO callback; just return the
	underlying OS call return value.

2016-02-25  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c: The FSIO open(2) callback in
	mod_statcache was only clearing the cached value IFF open(2)
	returned zero.  But open(2) returns zero OR GREATER on success.
	Oops.

2016-02-25  TJ Saunders <tj@castaglia.org>

	* src/fsio.c: Cache the close(2) errno value, to avoid it being
	changed by later code in pr_fsio_close().

2016-02-25  TJ Saunders <tj@castaglia.org>

	* doc/contrib/mod_unique_id.html: Fix HTML markup.

2016-02-25  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c: Add a fake 451 response code for aborted
	SFTP file transfers.

2016-02-23  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c: Automatically disable negative caching
	for SSH2 sessions.

2016-02-23  TJ Saunders <tj@castaglia.org>

	* NEWS: Add mention of fix for Bug#4227.

2016-02-23  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #220 from proftpd/sftp-multi-init-bug4227 Bug#4227: Support SFTP clients that send multiple INIT requests.

2016-02-22  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c: Only increment the bytes transferred
	values, when handling an SFTP WRITE request, once the bytes have
	been successfully written, per write(2) result.

2016-02-22  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #219 from proftpd/sftp-no-stat-on-read Attempt to mitigate the issue with mod_statcache's stat() causing
	SFT…

2016-02-22  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c: Improve mod_statcache trace logging, to
	better differentiate among locking-related log messages.

2016-02-21  TJ Saunders <tj@castaglia.org>

	* RELEASE_NOTES, contrib/mod_tls.c, doc/contrib/mod_tls.html: Use a
	directive name of TLSServerInfoFile, for consistency with other
	mod_tls directives.

2016-02-20  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #217 from proftpd/tls-serverinfo Add TLSServerInfo directive, for TLS ServerHello extensions

2016-02-20  TJ Saunders <tj@castaglia.org>

	* RELEASE_NOTES, contrib/mod_tls.c, doc/contrib/mod_tls.html: 
	Implement a TLSServerInfo directive, for configuring custom TLS
	extension data (e.g. for SCT data).

2016-02-17  TJ Saunders <tj@castaglia.org>

	* contrib/mod_exec.c, contrib/mod_sftp/keys.c, contrib/mod_tls.c,
	modules/mod_rlimit.c, src/rlimit.c: Don't log spurious log messages
	if getrlimit(2) fails with ENOSYS/EPERM.

2016-02-16  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/blacklist.c: Quell Coverity warning by setting an
	upper bound on the number of records we are willing to scan/process
	from the blacklist.dat file.

2016-02-16  TJ Saunders <tj@castaglia.org>

	* lib/libltdl/ltdl.c: Quell Coverity warning about possible resource
	leak in libltdl.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/keys.c, contrib/mod_tls.c: Ensure proper
	NUL-termination of buffers in all cases.  Should make Coverity
	happier.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/base32.c: Use signed data types, to prevent
	underflow and bad shift operations.  Found by Coverity.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_statcache.c: Add check for return value, per Coverity.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/mod_auth_otp.c: Fix issue discovered by
	Coverity.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_digest.c: Fix issue detected by Coverity.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* doc/contrib/mod_auth_otp.html, doc/contrib/mod_digest.html,
	doc/contrib/mod_statcache.html: Update docs of new modules to
	mention where their source code is.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #214 from proftpd/contrib-statcache Adding mod_statcache to the contrib/ directory.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* .gitignore, .travis.yml, contrib/mod_auth_otp/mod_auth_otp.c: 
	Address build warnings, tweak the travis-ci setup.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in: Trying some reordering, when
	building mod_auth_otp as a DSO module.

2016-02-12  TJ Saunders <tj@castaglia.org>

	* contrib/mod_digest.c: Fix building of mod_digest as a shared
	module.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in: Back to the original.  Probably
	won't work.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in: Still correcting paths.  Sigh.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in,
	contrib/mod_auth_otp/mod_auth_otp.c: Still trying to get the
	travis-ci builds passing.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in: Tweak, tweak.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/Makefile.in: Still working on fixing the
	travis-ci build.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* contrib/mod_auth_otp/t/Makefile.in,
	contrib/mod_auth_otp/t/api/base32.c,
	contrib/mod_auth_otp/t/api/otp.c,
	contrib/mod_auth_otp/t/api/stubs.c,
	contrib/mod_auth_otp/t/api/tests.c,
	contrib/mod_auth_otp/t/api/tests.h: Add missing API tests for
	mod_auth_otp, breaking the travis-ci build.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* .travis.yml: Add mod_auth_otp, mod_digest to the travis-ci builds.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #213 from proftpd/contrib-auth-otp Adding mod_auth_otp to the contrib/ modules directory.

2016-02-11  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #212 from proftpd/contrib-digest Adding mod_digest module to contrib modules.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql.c: Log a warning about using the Plaintext
	SQLAuthType; it's a bad security policy, as it allows storing
	passwords IN THE CLEAR in the database.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* RELEASE_NOTES, contrib/mod_sql.c, include/mod_log.h,
	modules/mod_log.c, tests/t/lib/ProFTPD/Tests/Logging/ExtendedLog.pm: 
	Add a %{transfer-type} LogFormat variable; this is just one more
	variable needed to make an ExtendedLog that contains the same
	information as the fixed-format TransferLog.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* contrib/mod_wrap.c, modules/mod_core.c: Update mod_wrap to
	properly handle a HOST command.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* contrib/mod_quotatab.c, modules/mod_core.c: Update mod_quotatab to
	Do The Right Thing(tm) in the face of HOST commands.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* contrib/mod_wrap2/mod_wrap2.c, modules/mod_core.c: Update
	mod_wrap2 to properly handle HOST commands.

2016-02-01  TJ Saunders <tj@castaglia.org>

	* contrib/mod_radius.c, contrib/mod_rewrite.c, modules/mod_core.c: 
	Update the mod_radius and mod_rewrite modules to properly
	respond/handle HOST commands.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* contrib/mod_ldap.c, modules/mod_core.c: Make mod_ldap be
	HOST-aware, and reset its settings as necessary.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql_passwd.c, modules/mod_core.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sql_passwd.pm: Make sure that
	mod_sql_passwd works properly with respect to HOST commands.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql.c: Update mod_sql so that it Does The Right
	Thing(tm) for HOST commands.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* src/auth.c: Correct grammar in a trace log message; no functional
	change.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c: Update the list of modules needing HOST
	handling work.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* modules/mod_auth.c: Remove now-obsolete POST_CMD HOST handler; it
	was replaced by the 'core.session-reinit' event listener.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* modules/mod_auth.c,
	tests/t/lib/ProFTPD/Tests/Config/AnonAllowRobots.pm: Fix edge case
	with implementation of Bug#4224, where we do NOT want any automatic
	handling of "robots.txt" for non-anonymous logins.

2016-01-31  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #210 from
	proftpd/auth-anon-allow-robots-bug4224 Bug#4224: Prohibit FTP indexing by web crawlers via auto-generated
	ro…

2016-01-30  TJ Saunders <tj@castaglia.org>

	* locale/files.txt: Updated files.txt.

2016-01-30  TJ Saunders <tj@castaglia.org>

	* doc/contrib/mod_quotatab.html: Fix markup.

2016-01-29  TJ Saunders <tj@castaglia.org>

	* NEWS, RELEASE_NOTES, doc/modules/mod_auth.html,
	modules/mod_auth.c, tests/t/config/anonallowrobots.t,
	tests/t/lib/ProFTPD/Tests/Config/AnonAllowRobots.pm: Bug#4224:
	Prohibit FTP indexing by web crawlers via auto-generated robots.txt.

2016-01-29  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls.c: Properly shut down the TLS session on data
	connections as well.

2016-01-28  TJ Saunders <tj@castaglia.org>

	* doc/rfc/rfc7151.txt: Adding RFC 7151 to our RFCs area, since we
	now implement the HOST command.

2016-01-28  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #209 from proftpd/exists2 Restore backward compatibility

2016-01-28  TJ Saunders <tj@castaglia.org>

	* contrib/mod_copy.c, contrib/mod_sftp/fxp.c,
	contrib/mod_sftp/mod_sftp.c, contrib/mod_sftp/scp.c,
	contrib/mod_sql.c, contrib/mod_tls.c, include/support.h,
	modules/mod_core.c, modules/mod_ls.c, modules/mod_xfer.c,
	src/support.c, tests/api/misc.c: Restore backward compatibility by
	restoring the Support API's exists/mode functions back to their
	original signatures, and provide variants, which accept a pool, for
	the chroot+symlink-aware functionality.

2016-01-28  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #208 from proftpd/extlog-file-size-var-redux Use POST_CMD handlers for stashing the 'mod_xfer.file-size' note, so
	…

2016-01-27  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #207 from proftpd/extlog-file-size-var Add support for a %{file-size} LogFormat variable, which resolves to
	the

2016-01-27  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Config/AllowForeignAddress.pm: Add
	regression test for a site-to-site transfer of a >2GB file.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* NEWS: Update NEWS for fix for Bug#4219.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #206 from
	proftpd/fsio-chrooted-readlink-bug4219 Bug#4219: Better handling of symlinks when chrooted

2016-01-27  TJ Saunders <tj@castaglia.org>

	* modules/mod_site.c, tests/t/lib/ProFTPD/Tests/Modules/mod_site.pm: 
	Added regression tests for SITE CHMOD commands and symlinks,
	chrooted and not.  All tests pass properly now.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* modules/mod_site.c, tests/t/lib/ProFTPD/Tests/Modules/mod_site.pm: 
	Added regression tests for the SITE CHGRP command and symlinks,
	chrooted and not.  All tests pass now.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/scp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for SCP downloads to symlinks, chrooted and not.  Made sure
	the tests pass as expected.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* : commit 5dc63cc755fbc7fde7757812678b4d02eb54a654 Author: TJ
	Saunders <tj@castaglia.org> Date:   Wed Jan 27 11:15:37 2016 -0800

2016-01-27  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls.c: Add comment about where to find the definition
	of unknown TLS extension IDs.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql_mysql.c: If mod_sql_mysql fails to configure the
	character set, just log the failure and do not treat it as a fatal
	error, in order to better handle situations of client/server version
	skew.

2016-01-27  TJ Saunders <tj@castaglia.org>

	* doc/howto/Logging.html: Mention that FreeBSD ftpd does NOT use the
	xferlog(5) format.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* src/inet.c, src/support.c: Add Mac OSX-specific version macros for
	the newer OSX versions as needed.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* : commit 662a109c354eb72b9f138e1b332ba3fd3e088b88 Author: TJ
	Saunders <tj@castaglia.org> Date:   Tue Jan 26 16:54:44 2016 -0800

2016-01-26  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/STOU.pm: Add another regression
	test for Bug#4223, for the chroot case.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* modules/mod_xfer.c: Style nit; no functional change.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c: Add the dir_readlink() magic to the
	check-file SFTP extension handling.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for SFTP RMDIR requests and symlinks, chrooted and not.
	Ensured that all tests pass as expected.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for SFTP OPENDIR requests and symlinks, chrooted and not.
	Made sure the tests pass as expected.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for SFTP SETSTAT requests and symlinks, chrooted and not.
	Made sure that the tests pass properly.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for the SFTP STAT requests and symlinks, chrooted and not, and
	made sure the tests pass.

2016-01-26  TJ Saunders <tj@castaglia.org>

	* : commit 9a17b90289f876339b4cf71f74329a2d5fa3c4f9 Author: TJ
	Saunders <tj@castaglia.org> Date:   Tue Jan 26 10:47:03 2016 -0800

2016-01-26  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #205 from proftpd/xfer-stou-umask-bug4223 Bug#4223: Permissions on files uploaded via STOU do not honor
	configured Umask

2016-01-26  TJ Saunders <tj@castaglia.org>

	* modules/mod_xfer.c: Bug#4223: Permissions on files uploaded via
	STOU do not honor configured Umask.

2016-01-25  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for the SFTP OPEN requests and symlinks, chrooted and not.

2016-01-25  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Added regression
	tests for SFTP MKDIR requests and symlinks, chrooted and not.

2016-01-25  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/RNTO.pm: Added regression tests
	for the RNTO command, and symlinks.

2016-01-25  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c, tests/t/lib/ProFTPD/Tests/Commands/RNFR.pm: 
	Adding regression tests for the RNFR command and symlinks, chrooted
	and not.

2016-01-24  TJ Saunders <tj@castaglia.org>

	* : commit f8eded5488c03a40a02dbdb4056d6222e0a045a3 Author: TJ
	Saunders <tj@castaglia.org> Date:   Sun Jan 24 20:24:44 2016 -0800

2016-01-24  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #204 from proftpd/default-transfer-mode Move the processing of the DefaultTransferMode directive from
	mod_aut…

2016-01-24  TJ Saunders <tj@kiban.io>

	* modules/mod_auth.c, modules/mod_core.c: Move the processing of the
	DefaultTransferMode directive from mod_auth to mod_core.  The
	directive handler is in mod_core, and the processing is more
	properly done as a post-PASS step.

2016-01-24  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c, modules/mod_xfer.c,
	tests/t/lib/ProFTPD/Tests/Commands/RMD.pm: Added regression tests
	for RMD and symlinks, and made sure that symlinks could be handled
	properly when chrooted.

2016-01-24  TJ Saunders <tj@castaglia.org>

	* modules/mod_xfer.c, tests/t/lib/ProFTPD/Tests/Commands/RETR.pm: 
	Added regression tests for RETR and symlinks, and updated the RETR
	handling to use dir_readlink(), so that symlinks can be retrieved
	when chrooted.

2016-01-24  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c, tests/t/lib/ProFTPD/Tests/Commands/CWD.pm: 
	Added regression tests for the CWD and symlinks, and made sure that
	CWD does The Right Thing(tm) with symlinks, chrooted and not.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* : commit e09990a3840ddca4413160c86ab0eff403c3a698 Author: TJ
	Saunders <tj@castaglia.org> Date:   Fri Jan 22 16:09:02 2016 -0800

2016-01-22  TJ Saunders <tj@castaglia.org>

	* src/fsio.c: Fix log messages to be grammatically correct.

2016-01-22  TJ Saunders <tj@kiban.io>

	* src/str.c, tests/api/str.c: For better logging/debugging, have the
	{uid,gid}2str() functions return "-1" for cases where the
	uid_t/gid_t have that value, as they are used as sentinel values in
	the core code.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/MKD.pm: Updated MKD regression
	tests to use test_setup()/test_cleanup(), in preparation to adding
	more symlink-related regression tests.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* modules/mod_core.c, tests/t/lib/ProFTPD/Tests/Commands/MDTM.pm: 
	Update the handling of the MDTM command for chrooted symlinks, with
	accompanying regression tests.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/MDTM.pm: First, update the MDTM
	regression tests to use test_setup() and test_cleanup().  Next, I'll
	add regression tests for MDTM on symlinks (to files and
	directories).

2016-01-22  TJ Saunders <tj@castaglia.org>

	* contrib/mod_copy.c: Found another place needing updating for the
	change of exists() signature.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql.c, contrib/mod_tls.c: Updated some contrib
	modules, due to changes in the Support API signatures.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/APPE.pm: Make sure that the
	destination path correctly lines up with the (adjusted) chroot on
	MacOSX.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c, contrib/mod_sftp/mod_sftp.c,
	contrib/mod_sftp/scp.c, include/support.h, modules/mod_core.c,
	modules/mod_ls.c, modules/mod_xfer.c, src/support.c,
	tests/api/misc.c, tests/t/lib/ProFTPD/Tests/Commands/APPE.pm: Added
	more regression tests for the APPE command, for absolute destination
	path symlinks and chroots, which required some refactoring of the
	core library.

2016-01-22  TJ Saunders <tj@castaglia.org>

	* doc/howto/ListOptions.html, doc/modules/mod_facts.html,
	doc/modules/mod_ls.html: Update docs to mention new
	'NoAdjustedSymlinks' options for mod_facts, mod_ls.

2016-01-22  TJ Saunders <tj@kiban.io>

	* doc/howto/CreateHome.html: Updated links to the main docs for the
	CreateHome directive.

2016-01-21  TJ Saunders <tj@kiban.io>

	* contrib/mod_sftp_pam.c: Now the mod_sftp_pam module will check for
	the AuthPAM directive, in addition to SFTPPAMEngine, to better work,
	as expected, with existing proftpd configurations that use AuthPAM.  See:
	http://serverfault.com/questions/386294/proftpd-with-sftp-first-login-fails-seconds-succeeds

2016-01-21  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/DELE.pm: Modernized some of the
	DELE regression tests in preparation, but then realized that DELE's
	handling of symlinks just does The Right Thing(tm), regardless of
	chroots.

2016-01-21  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/APPE.pm: Adding APPE regression
	tests for symlinks, chrooted and not.

2016-01-21  TJ Saunders <tj@castaglia.org>

	* modules/mod_xfer.c: Rename a variable to be more consistent with
	usage elsewhere, i.e. using 'xerrno' as the errno holder, not
	'ferrno'.

2016-01-21  TJ Saunders <tj@kiban.io>

	* include/ftp.h: Remove redundant redefinition of the C_HOST macro.

2016-01-21  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/LIST.pm: Adding regression
	tests for the LIST command, with regard to symlinks, ShowSymlinks,
	and chroots.

2016-01-21  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/NLST.pm: Added NLST regression
	tests for symlinks, and symlinks when chrooted.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* src/support.c, tests/api/misc.c: Clean up the returned destination
	paths, even when not chrooted.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Commands/STAT.pm: Updated the STAT
	regression tests, and added missing tests for symlinks, both when
	chrooted and not.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* tests/api/misc.c: Fix the broken unit tests.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* modules/mod_facts.c, src/support.c, tests/api/misc.c,
	tests/t/lib/ProFTPD/Tests/Commands/MLSD.pm,
	tests/t/lib/ProFTPD/Tests/Commands/MLST.pm: Update mod_facts to use
	dir_readlink() for MLST/MLSD commands.  Turns out that this fixes an
	already-existing bug, where symlinks were not being handled well
	when the session is chrooted anyway.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* src/fsio.c: Remove some distracting FSIO statcache trace logging
	by explicitly setting errno to zero for success cases.

2016-01-20  TJ Saunders <tj@castaglia.org>

	* src/dirtree.c: Move some noisy AllowOverride logging to trace
	logging, from debug logging.

2016-01-19  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sftp.pm: Update mod_sftp's
	handling of the READLINK request to use the new chroot-aware
	dir_readlink() function.

2016-01-19  TJ Saunders <tj@castaglia.org>

	* : commit 632cc9dd493e263f66fb42dd54809cb3f671b17b Merge: d55f831
	5fd7508 Author: TJ Saunders <tj@castaglia.org> Date:   Tue Jan 19
	09:56:04 2016 -0800

2016-01-19  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql.c,
	tests/t/lib/ProFTPD/Tests/Modules/mod_sql_sqlite.pm: Make sure that
	mod_sql can also handle the new %R, %{transfer-millisecs} variables
	from Bug#4218.

2016-01-19  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #202 from proftpd/privs-coverage Increase test coverage of the Privs API.

2016-01-19  TJ Saunders <tj@castaglia.org>

	* include/privs.h, src/privs.c, tests/api/privs.c: Attempt to
	increase test coverage of the Privs API by providing a function for
	setting the "am I running as nonroot?" flag, to be used by unit
	tests.

2016-01-19  TJ Saunders <tj@castaglia.org>

	* include/support.h, src/support.c, tests/api/misc.c: Provide flags,
	for handling relative destination symlink paths (or not).  Update
	the unit tests to cover the new branches.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* src/support.c, tests/api/misc.c: If dir_readlink() reads in a
	relative path, and that path falls within the chroot, try to
	emit/provide a relative path as output, in order to preserve the
	principle of least surprise.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* include/support.h, src/support.c, tests/api/misc.c: First part of
	Bug#4219: provide a support function which wraps pr_fsio_readlink(),
	and does the chroot checking/adaptation.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* src/fsio.c: Handle the edge case where a custom FSIO object does
	not provide a readlink implementation, and that callback is thus
	NULL.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Modules/mod_snmp.pm: Update the mod_snmp
	tests to pass properly, when more contrib modules (e.g.  mod_tls,
	mod_sftp, mod_ban) are present.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* contrib/mod_snmp/mod_snmp.c: Remove some logically unneeded code,
	per Coverity.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* contrib/mod_snmp/PROFTPD-MIB.txt: Remove CVS tag, now that we're
	in Git.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* .gitignore: Ignore the Coverity cov-int directory, too.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* modules/mod_ctrls.c: Avoid unnecessary (and redundant) null check,
	per Coverity.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* src/dirtree.c: Catch/handle a possible null pointer dereference,
	per Coverity.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sql_passwd.c: Pedantically check for possible null
	values, per Coverity.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls_fscache.c: Implement permission checks on the
	directory for caching OCSP responses, and avoid world-writable
	directories.

2016-01-18  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls_fscache.c: Be a little more strict when checking
	permissions for cached OCSP responses, by calling open(2) on the
	path, then using fstat(2), rather than just using lstat(2).  This
	should make Coverity happier.  Hopefully.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* NEWS, RELEASE_NOTES: Updates NEWS, release notes with mention of
	Bug#4218.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* : Merge pull request #201 from
	proftpd/extlog-response-transfer-millisecs-bug4218 Bug#4218: Support a LogFormat variable for logging command duration
	in milliseconds

2016-01-17  TJ Saunders <tj@castaglia.org>

	* doc/modules/mod_log.html, include/mod_log.h, modules/mod_log.c,
	tests/t/lib/ProFTPD/Tests/Logging/ExtendedLog.pm: Implement the
	%{transfer-millisecs} LogFormat variable, with regression test.  In
	doing so, the implementation of the %T LogFormat variable was made
	much simpler.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* tests/t/lib/ProFTPD/Tests/Logging/ExtendedLog.pm: First step: add
	missing regression test for the %T LogFormat variable, to be used as
	a template for the next part.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* tests/api/misc.c: Now we're playing with platform-specific
	behaviors.  Whee!

2016-01-17  TJ Saunders <tj@castaglia.org>

	* tests/api/str.c: Quell compiler warning about mismatched types.

2016-01-17  TJ Saunders <tj@kiban.io>

	* include/support.h, modules/mod_ls.c, src/support.c,
	tests/api/misc.c: Still working out the kinks with the rewritten
	get_name_max().

2016-01-17  TJ Saunders <tj@castaglia.org>

	* tests/api/misc.c: The rewriting of get_name_max() changed the test
	expectations.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* src/support.c: Rewrite the get_name_max() function to be more
	legible, and avoid (hopefully) the rats' nest of ifdefs.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* src/netio.c: At least check if our stashing of the NetIO in the
	notes fails, per Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* modules/mod_ls.c: Avoid memory leak under error conditions; found
	by Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls.c: Avoid memory leak in edge case scenario; found
	by Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* contrib/mod_tls.c: Avoid an unneeded loop, which avoids logically
	dead code.  Found by Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* modules/mod_dso.c: Avoid checking a pointer that we already know
	to be null (due to earlier checks), per Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* src/log.c: Be more paranoid about checking for null pointers, per
	Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* contrib/mod_exec.c: It's possible for exec_subst_var() to be
	called with a null cmd_rec, thus we need to guard against such
	conditions.  Found by Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* contrib/mod_sftp/fxp.c: Remove unused code, detected by Coverity.

2016-01-17  TJ Saunders <tj@castaglia.org>

	* contrib/coverity/modeling.c: Update the Coverity modeling file, to
[--snip--]
